commit 7e8120c0574ab1910f63474ff6be8de0ddc4ccac Author: Alan Coopersmith Date: Fri Aug 26 15:23:32 2022 -0700 libFS 1.0.9 Signed-off-by: Alan Coopersmith commit ee33ecf31706877e1ab7dc257fadbb3eb535da50 Author: Alan Coopersmith Date: Sun May 8 12:35:00 2022 -0700 Convert code to use FSmallocarray() & FSreallocarray() Provides automatic integer overflow checking in allocation size calculations (Though we already have explicit checks before using values provided over the protocol in calculations, so many were already manually checked.) Signed-off-by: Alan Coopersmith commit 4a1d0977dbb6eb960ca4deedba90940bcaeecefb Author: Alan Coopersmith Date: Sun May 8 12:20:58 2022 -0700 Import reallocarray() from libX11 (originally from OpenBSD) Wrapper for realloc() that checks for overflow when multiplying arguments together, so we don't have to add overflow checks to every single call. For documentation on usage, see: http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man3/calloc.3 Signed-off-by: Alan Coopersmith commit 8896fbce317e454e578cc80300693737e39e00fc Author: Alan Coopersmith Date: Sun May 8 12:05:16 2022 -0700 gitlab CI: add a basic build test Signed-off-by: Alan Coopersmith commit 29f790a5c98abde13b3daa5a7b1c1f53c4574550 Author: Alan Coopersmith Date: Sun May 8 12:01:22 2022 -0700 Fix spelling/wording issues Found by using: codespell --builtin clear,rare,usage,informal,code,names Signed-off-by: Alan Coopersmith commit aea1ce86c4391ba72de4e8599f3862eccd3599f0 Author: Alan Coopersmith Date: Sun May 8 12:00:23 2022 -0700 Build xz tarballs instead of bzip2 Signed-off-by: Alan Coopersmith commit 02de7390e58f00a3701f656a2b205dc6c8dafb58 Author: Alan Coopersmith Date: Sun Mar 10 15:39:06 2019 -0700 libFS 1.0.8 Signed-off-by: Alan Coopersmith commit e8642e3203f9793c2cca19b2df334b4160c56742 Author: Alan Coopersmith Date: Fri Dec 7 19:29:44 2018 -0800 Update configure.ac bug URL for gitlab migration Signed-off-by: Alan Coopersmith commit 6052aa6479be8059c9294ced6e3a33e2316bb2d5 Author: Alan Coopersmith Date: Sun Nov 18 21:46:25 2018 -0800 Update README for gitlab migration Signed-off-by: Alan Coopersmith commit d3af455fb236931fadb6e863e5a4ed509c61d868 Author: Alan Coopersmith Date: Sun Sep 23 19:26:02 2018 -0700 Don't try to send strings larger than protocol allows in requests Also clears up all "Loss of precision on implicit conversion" warnings from Oracle's Parfait static analyser. Signed-off-by: Alan Coopersmith commit 12d64c65200930885c694d018ec66d8946b3a214 Author: Alan Coopersmith Date: Sun Sep 23 13:51:25 2018 -0700 Fix sign comparison warning in loop index in FSQueryXInfo FSQXInfo.c: In function ‘FSQueryXInfo’: FSQXInfo.c:110:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (j=0; jnum_offsets; j++) ^ Signed-off-by: Alan Coopersmith commit 3eb9c6bbfb4e6caf6efb5dec8744f257c2d63be7 Author: Alan Coopersmith Date: Sun Sep 23 13:47:35 2018 -0700 Fix sign comparison warning in loop indexes in FSQueryXExtents{8,16} FSQXExt.c: In function ‘FSQueryXExtents8’: FSQXExt.c:105:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < reply.num_extents; i++) { ^ FSQXExt.c: In function ‘FSQueryXExtents16’: FSQXExt.c:141:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < str_len; i++) { ^ FSQXExt.c:165:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < reply.num_extents; i++) { ^ Signed-off-by: Alan Coopersmith commit 8213b7070c039ea16d0112eff01cc7420031c089 Author: Alan Coopersmith Date: Sun Sep 23 13:44:59 2018 -0700 Fix sign comparison warning in loop indexes in FSQueryXBitmaps{8,16} FSQGlyphs.c: In function ‘FSQueryXBitmaps8’: FSQGlyphs.c:113:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i=0; i commit caee4c2bf188484f117e5bd866e3b56c8506593e Author: Alan Coopersmith Date: Sun Sep 23 13:40:30 2018 -0700 Fix sign comparison warning in loop index in FSListCatalogues FSListCats.c: In function ‘FSListCatalogues’: FSListCats.c:104:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < rep.num_catalogues; i++) { ^ Signed-off-by: Alan Coopersmith commit b37bbeb7ca931b0f5170e877b0bbfd0959d344b7 Author: Alan Coopersmith Date: Sun Sep 23 13:34:04 2018 -0700 Fix sign comparison warning in loop index in FSListFontsWithXInfo FSFontInfo.c: In function ‘FSListFontsWithXInfo’: FSFontInfo.c:182:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (j=0; jnum_offsets; j++) ^ Signed-off-by: Alan Coopersmith commit fed3794a5204eace3926f13573b10f0b51f85fbc Author: Mihail Konev Date: Thu Jan 26 13:52:49 2017 +1000 autogen: add default patch prefix Signed-off-by: Mihail Konev commit 89f456580ea831652f119158f8b257dfd531a7e1 Author: Emil Velikov Date: Mon Mar 9 12:00:52 2015 +0000 autogen.sh: use quoted string variables Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer commit 4ef3748251ac2139b73b137dcef529421447652b Author: Peter Hutterer Date: Tue Jan 24 10:32:07 2017 +1000 autogen.sh: use exec instead of waiting for configure to finish Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer Reviewed-by: Emil Velikov commit a9db12661e7412dd935706c92db6d7bc46238782 Author: Alan Coopersmith Date: Thu Apr 30 21:14:46 2015 -0700 libFS 1.0.7 Signed-off-by: Alan Coopersmith commit f1c9c18e2601151e3dfa7f83b4748edd2a5a3a6e Author: Alan Coopersmith Date: Wed Nov 5 17:49:30 2014 -0800 Use 'imdent' to realign cpp indentation levels in FSlibos.h Parts were indented, others weren't, now is more consistent. 'git diff -w' shows no non-whitespace changes in this commit Signed-off-by: Alan Coopersmith commit f2c0bb056dbfbc2ca5b753b8de87b6c73742a990 Author: Alan Coopersmith Date: Wed Nov 5 17:48:18 2014 -0800 Remove unneeded checks for #ifndef X_NOT_POSIX Signed-off-by: Alan Coopersmith commit aef4c4f1330dc01d535cd88b9805c3d5d164b070 Author: Alan Coopersmith Date: Fri Jul 11 20:24:22 2014 -0700 Fix typos & wording issues in source comments Signed-off-by: Alan Coopersmith commit dcf25b1ed387d7019d2cf7703eeb33554987d63f Author: Alan Coopersmith Date: Thu Jun 5 14:20:07 2014 -0700 Fix some sign/size conversion warnings from clang Signed-off-by: Alan Coopersmith commit fa577a18f189fe454995306d38059570e1ad8bf2 Author: Alan Coopersmith Date: Wed Jun 4 23:36:45 2014 -0700 Constify some more strings in API arguments Signed-off-by: Alan Coopersmith commit 5e0f1b91edb97759e2c07ec233c2ce8639c8e0fe Author: Alan Coopersmith Date: Fri May 23 23:20:03 2014 -0700 Constify pattern argument to FSListCatalogues The contents of pattern are simply copied to the request sent to the font server and never touched again, so can be labeled read-only. Fixes compiler warning building xfsinfo: xfsinfo.c: In function ‘print_catalogue_info’: xfsinfo.c:158:5: warning: passing argument 2 of ‘FSListCatalogues’ discards ‘const’ qualifier from pointer target type [enabled by default] char **cats = FSListCatalogues(svr, "*", 1000, &n); ^ In file included from xfsinfo.c:66:0: FSlib.h:255:16: note: expected ‘char *’ but argument is of type ‘const char *’ extern char ** FSListCatalogues ( FSServer *svr, char *pattern, Signed-off-by: Alan Coopersmith commit 88be5c37c40070305e64c4b8dc0a1c1f6ca80440 Author: Alan Coopersmith Date: Sun Mar 16 10:44:14 2014 -0700 libFS 1.0.6 Signed-off-by: Alan Coopersmith commit e5be46eceee9c0c0d5f0363d3e08b19f86f85fcb Author: Alan Coopersmith Date: Fri Jan 3 23:07:12 2014 -0800 Use strlcpy instead of strcpy/strncpy if it is available Signed-off-by: Alan Coopersmith commit e831ef9246684298c147f9b26de0810b8218c3cb Author: Alan Coopersmith Date: Fri Jan 3 21:33:10 2014 -0800 Replace malloc(strlen + 1); strcpy() with strdup() Signed-off-by: Alan Coopersmith Reviewed-by: Jasper St. Pierre commit 980cf8ac0c636ff7ef1fccb9e74f116ac5ea34ae Author: Alan Coopersmith Date: Fri Jan 3 21:13:30 2014 -0800 Remove unused internal helper _FSWireToEvent Since we build with -export-symbols-regex '^FS.*', it wasn't available to callers outside libFS, and was never called by anything inside libFS. Seems to have been imported from XlibInt.c without ever being used. Flagged by cppcheck 1.62: [FSlibInt.c:753]: (style) The function '_FSWireToEvent' is never used. Signed-off-by: Alan Coopersmith Reviewed-by: Jasper St. Pierre commit b9f27dc863c3ca01bb231ee48e84bc60b39d4f1f Author: Alan Coopersmith Date: Fri Jan 3 20:55:33 2014 -0800 Remove unused internal helper _FSEventsQueued Since we build with -export-symbols-regex '^FS.*', it wasn't available to callers outside libFS, and was never called by anything inside libFS. Seems to have been imported from XlibInt.c without ever being used. Flagged by cppcheck 1.62: [FSlibInt.c:180]: (style) The function '_FSEventsQueued' is never used. Signed-off-by: Alan Coopersmith Reviewed-by: Jasper St. Pierre commit 37772516acb95b3c9934252994b7dfdc147dfd23 Author: Alan Coopersmith Date: Fri Jan 3 20:50:32 2014 -0800 Remove unused internal helper _FSAllocScratch Since we build with -export-symbols-regex '^FS.*', it wasn't available to callers outside libFS, and was never called by anything inside libFS. Seems to have been imported from XlibInt.c without ever being used. The _FSserver fields that it used (and nothing else did) are replaced with "unused" placeholders to maintain struct layout/size. Flagged by cppcheck 1.62: [FSlibInt.c:973]: (style) The function '_FSAllocScratch' is never used. Signed-off-by: Alan Coopersmith Reviewed-by: Jasper St. Pierre commit ac1eb6e3ea54724cf3ab3ad1ccf0595df9e34786 Author: Alan Coopersmith Date: Fri Jan 3 20:46:48 2014 -0800 Remove unused internal helper _FSGetHostname Since we build with -export-symbols-regex '^FS.*', it wasn't available to callers outside libFS, and was never called by anything inside libFS. Xtrans provides it's own exact copy of this function, which gets the name _FSTransGetHostname when built in libFS, nothing in libFS outside the Xtrans code calls a gethostname() function. Flagged by cppcheck 1.62: [FSlibInt.c:1060]: (style) The function '_FSGetHostname' is never used. Signed-off-by: Alan Coopersmith Reviewed-by: Jasper St. Pierre commit a4c12fe0ca5cb359bffe08b26a92ddcf8e194441 Author: Alan Coopersmith Date: Fri Jan 3 20:04:33 2014 -0800 If EAGAIN == EWOULDBLOCK, only need to check errno for one of them Solaris has: #define EWOULDBLOCK EAGAIN so checking (errno == EAGAIN || errno == EWOULDBLOCK) is overkill. This leads cppcheck 1.62 to complain: [FSlibInt.c:153] -> [FSlibInt.c:153]: (style) Same expression on both sides of '||'. [FSlibInt.c:301] -> [FSlibInt.c:301]: (style) Same expression on both sides of '||'. [FSlibInt.c:379] -> [FSlibInt.c:379]: (style) Same expression on both sides of '||'. [FSlibInt.c:472] -> [FSlibInt.c:472]: (style) Same expression on both sides of '||'. This quiets it, and reduces the number of calls Solaris Studio cc generates to the __errno() function to get the thread-specific errno value. Signed-off-by: Alan Coopersmith Reviewed-by: Jasper St. Pierre commit b6885f7aedc3b6eba62ffa1edac1e8488d938cea Author: Alan Coopersmith Date: Fri Jan 3 19:57:09 2014 -0800 Reduce scope & remove unneeded assignment of defaultp in FSGetErrorText() Suggested by cppcheck 1.62 Signed-off-by: Alan Coopersmith commit dcb6c39feb63dcf7e843bd2394a2544fd4e79f9f Author: Jeremy Huddleston Sequoia Date: Thu Jan 2 01:03:49 2014 -0800 FSOpenServer: Fix double-free in error path FSOpenServ.c:266:5: warning: Use of memory after it is freed OutOfMemory(svr, setup); ^~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Jeremy Huddleston Sequoia commit 4b0b74f953619164dc2863ee2cd3f09d15c65a51 Author: Jeremy Huddleston Sequoia Date: Thu Jan 2 00:49:27 2014 -0800 Update error loop to correctly handle error in i==0 case FSOpenServ.c:183:3: warning: Function call argument is an uninitialized value FSfree(alts[i].name); ^~~~~~~~~~~~~~~~~~~~ ./FSlibos.h:273:21: note: expanded from macro 'FSfree' ^~~~~~~~~~~ Signed-off-by: Jeremy Huddleston Sequoia commit 5ed8b4cf1f1c35ef35a3c94350e6b96646a2a0b7 Author: Alan Coopersmith Date: Fri Dec 27 11:01:35 2013 -0800 Add AC_USE_SYSTEM_EXTENSIONS to expose non-standard extensions Required on Solaris to expose fd_mask in now that xtrans 1.3 defines _XOPEN_SOURCE to 600 on Solaris, since fd_mask is not defined in that version of the XPG standards. Fixes build failure: ../../src/FSConnServ.c: In function '_FSWaitForWritable': ../../src/FSConnServ.c:166:6: error: 'fd_mask' undeclared (first use in this function) ../../src/FSConnServ.c:166:6: note: each undeclared identifier is reported only once for each function it appears in Signed-off-by: Alan Coopersmith Reviewed-by: Daniel Stone commit 19ca53de0aae67b1f23085c832b445576c6a0b25 Author: Adam Jackson Date: Fri Nov 1 11:14:58 2013 -0400 Fix build with xtrans 1.3 ->Readv was in fact being used, oops. Just call straight down to readv() instead. Reviewed-by: Peter Harris Signed-off-by: Adam Jackson commit 96243bfec19d0f543de3ef590a482f7f6dcdaa3d Author: Alan Coopersmith Date: Mon Jun 24 22:52:09 2013 -0700 Drop Cray (WORD64/MUSTCOPY) support Signed-off-by: Alan Coopersmith commit d30a927b79ee0faa5f4547d5d60570f8fcd11fc2 Author: Alan Coopersmith Date: Mon Jun 24 22:46:52 2013 -0700 Fix a couple comment typos Signed-off-by: Alan Coopersmith commit 665fb8c34183bbaba5c7deb045863090082f814b Author: Alan Coopersmith Date: Mon Jun 24 22:42:56 2013 -0700 Require ANSI C89 pre-processor, drop pre-C89 token pasting support Signed-off-by: Alan Coopersmith commit 279fbcc23d6cd462e034dec6a9d1378cb86247e3 Author: Alan Coopersmith Date: Tue May 28 17:42:06 2013 -0700 Fix typo in readme ("xfslsfonts" should be "fslsfonts") Signed-off-by: Alan Coopersmith commit 9d1458e02fe8dcac68b32917c9b10fa49d7161e7 Author: Alan Coopersmith Date: Tue May 28 17:17:40 2013 -0700 libFS 1.0.5 Signed-off-by: Alan Coopersmith commit 26dc23446c2e7818fdebfb46e101bac4883df07e Author: Alan Coopersmith Date: Sun Apr 14 09:07:32 2013 -0700 Sign extension issue and integer overflow in FSOpenServer() [CVE-2013-1996] > altlen = (int) *ad++; <-- if char is 0xff, will sign extend to int (0xffffffff == -1) > alts[i].name = (char *) FSmalloc(altlen + 1); <-- -1 + 1 == 0 > ... > memmove(alts[i].name, ad, altlen); <-- memory corruption Reported-by: Ilja Van Sprundel Signed-off-by: Alan Coopersmith commit f6030dd569094fb29720a4bf54aec784b1edcac5 Author: Alan Coopersmith Date: Wed Apr 10 21:43:40 2013 -0700 Get rid of more duplication in error cleanup code in FSListFontsWithXInfo Also get rely on free() to handle null pointers in cleanup code instead of checking each one ourselves. Signed-off-by: Alan Coopersmith commit 1f260bfdcb8d83d6c21db70ad6ed0fa94e5f5abf Author: Alan Coopersmith Date: Wed Apr 10 20:55:36 2013 -0700 Avoid accessing freed memory on realloc failure in FSListFontsWithXInfo Since we realloc 5 things in a row, and then check for failure, it's quite possible one of our old pointers is now pointing to something completely different, so instead update the pointers as we successfully realloc them and then jump to the normal error processing cleanup if one fails. Signed-off-by: Alan Coopersmith commit 3022dfdcdac08a4950695ded9f372e845f2be008 Author: Alan Coopersmith Date: Wed Apr 10 19:04:22 2013 -0700 Avoid reading outside bounds when _FSReply receives an Error response Upon receiving a response, _FSReply copies the first 8 bytes into *rep and then looks at them to determine what type of response. If it's an error packet, it then converts to an error struct and reads the rest, but it was copying 16 bytes out of *rep to begin with, due to sloppy casting. Since we immediately overwrite the second 8 bytes with the data coming off the wire, this isn't horrible, but it really freaks out static analysis and memory debugging tools. Fixes parfait 1.1 warning: Error: Buffer overrun Read Outside Array Bounds in STD C function: Read outside array bounds in call to llvm.memcpy.p0i8.p0i8.i64. Buffer ((char*)((union fsError*)rep)) of size ??? is read at an offset of 16 size(((char*)((union fsError*)rep))) is 8, 16 is 16 at line 751 of src/FSlibInt.c in function '_FSReply'. called at line 67 of src/FSSync.c in function 'FSSync' with rep = ((union fsReply*)&rep). Signed-off-by: Alan Coopersmith commit 932131874109931bb6d50acc47ac94e51a2353de Author: Alan Coopersmith Date: Wed Apr 10 18:54:35 2013 -0700 Use NULL instead of 0 for null pointers Signed-off-by: Alan Coopersmith commit 90b9754da977cb6804da4c38711ff33db772a9ca Author: Alan Coopersmith Date: Wed Apr 10 18:30:24 2013 -0700 Get rid of unnecessary casts in FSfree calls No need to cast all other pointers to char *, since C89 free takes any type of pointer. Casting all of them just hides errors if you try to free something that's not really a pointer. Signed-off-by: Alan Coopersmith commit 2cf3ed903048758ee696d410aba6afefd1582dec Author: Alan Coopersmith Date: Wed Apr 10 18:26:22 2013 -0700 Get rid of unnecessary casts in FS*alloc calls Stop taking 64-bit size_t, truncating to 32-bit unsigned int, and then putting into a 64-bit size_t argument to underlying *alloc call. Also stop casting results, since in C, that just hides missing prototype errors that can cause memory corruption when taking an implicit 32-bit int return value and trying to make a 64-bit pointer out of it. Signed-off-by: Alan Coopersmith commit 0ef550010ad1cb08297951b385c0034010e89a9a Author: Alan Coopersmith Date: Fri Jan 18 23:18:47 2013 -0800 Replace deprecated Automake INCLUDES variable with AM_CPPFLAGS Excerpt https://lists.gnu.org/archive/html/automake/2012-12/msg00038.html - Support for the long-deprecated INCLUDES variable will be removed altogether in Automake 1.14. The AM_CPPFLAGS variable should be used instead. This variable was deprecated in Automake releases prior to 1.10, which is the current minimum level required to build X. Signed-off-by: Alan Coopersmith commit 464fb353a406cbb4c478fae89952979cb5c8775c Author: Colin Walters Date: Wed Jan 4 17:37:06 2012 -0500 autogen.sh: Implement GNOME Build API http://people.gnome.org/~walters/docs/build-api.txt Signed-off-by: Adam Jackson commit 0e0109c5d035c9f803b52d2189151f600de59866 Author: Adam Jackson Date: Tue Jan 15 14:28:48 2013 -0500 configure: Remove AM_MAINTAINER_MODE Signed-off-by: Adam Jackson commit 56c83935a873fa7c6bb0c8c7d9f755ee08439aa5 Author: Thomas Klausner Date: Thu Jul 12 14:39:26 2012 +0200 Fix a prototype error Per NetBSD PR 41899 from Henning Petersen. Signed-off-by: Thomas Klausner Signed-off-by: Julien Cristau commit 589eea0713cacb7b6889d15e4dbcd2914684db9b Author: Alan Coopersmith Date: Fri Mar 2 19:47:42 2012 -0800 libFS 1.0.4 Signed-off-by: Alan Coopersmith commit 9e5c931053f261cc97e3d7b75a5c2f14990bbb9d Author: Alan Coopersmith Date: Fri Mar 2 19:42:18 2012 -0800 Remove unneeded shadow definition of 'i' from FSQueryXBitmaps16 Fixes gcc warning: FSQGlyphs.c: In function 'FSQueryXBitmaps16': FSQGlyphs.c:153:6: warning: declaration of 'i' shadows a previous local FSQGlyphs.c:143:10: warning: shadowed declaration is here Signed-off-by: Alan Coopersmith commit 4ebfa48f74deb4f35490e02eeeb1e59ff56856ab Author: Alan Coopersmith Date: Sun Dec 4 08:54:38 2011 -0800 Fix builds of FSlibInt.c with Solaris Studio compilers Required in order to build with Studio cc now that xorg-macros is setting -errwarn=E_FUNC_HAS_NO_RETURN_STMT since a bug in the Solaris system headers causes the noreturn attribute to not be correctly applied to the exit() prototype in when building with Studio instead of gcc. Otherwise compiler exits with error: "FSlibInt.c", line 976: Function has no return statement : _FSDefaultIOError Uses Studio-specific pragma instead of adding another exit() prototype with a noreturn attribute to avoid causing gcc to warn about having a redundant prototype for the exit() function. Signed-off-by: Alan Coopersmith commit 447b3268bfb2d6a92d105ad75c2ac5462f1adecb Author: Alan Coopersmith Date: Fri Nov 11 22:54:21 2011 -0800 Mark pattern argument to FSListFonts* as const char * Needed to fix gcc -Wwrite-strings warnings in clients such as fslsfonts Signed-off-by: Alan Coopersmith commit 5dae1f32a775c3f99f26571f3fab8fb4f0f2874f Author: Alan Coopersmith Date: Wed Sep 28 22:28:22 2011 -0700 Change FSOpenServer and FSServerName to take const char * args. Almost matches the current versions of the XOpenDisplay & XDisplayName functions they're modeled on - unlike XDisplayName, FSServerName now returns const char * as well so we don't lose the constness of the string passed in if we return it. Signed-off-by: Alan Coopersmith commit 1353bd6b52241857f9e37cc6403e1fee3c5e69e4 Author: Alan Coopersmith Date: Mon Sep 26 15:07:57 2011 -0700 Add const attributes to fix gcc -Wwrite-strings warnings Signed-off-by: Alan Coopersmith commit 750fbfe7562e94788e5dfecb6617e26d6d3f0157 Author: Alan Coopersmith Date: Fri Sep 16 22:08:05 2011 -0700 Strip trailing whitespace Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}' git diff -w & git diff -b show no diffs from this change Signed-off-by: Alan Coopersmith commit 06fd3e765d96fda0e323c11c7a6786b870655bbe Author: Jeremy Huddleston Date: Thu Apr 28 17:21:15 2011 -0700 Silence clang's -Wformat-nonliteral around our error printing code Signed-off-by: Jeremy Huddleston commit b39bb910ce7a8dc18922957bad7c0e7b1fe9c499 Author: Jeremy Huddleston Date: Thu Apr 28 17:11:05 2011 -0700 Annotate fatal errors with _X_NORETURN Fixes a false-positive with clang static analysis Signed-off-by: Jeremy Huddleston commit 8607b9de7b331f7a97e623b1490194324a8b9a4b Author: Cyril Brulebois Date: Fri Feb 18 21:17:12 2011 +0100 Silence gcc warning. Fix the build with CFLAGS="-Wall -Werror": | CC FSGetErrorText.o | cc1: warnings being treated as errors | FSGetErrorText.c: In function ‘CheckErrorMessage’: | FSGetErrorText.c:43: error: format ‘%d’ expects type ‘int’, but argument 5 has type ‘long unsigned int’ An int is likely to be sufficient for this buffer's size… Signed-off-by: Cyril Brulebois Signed-off-by: Alan Coopersmith commit 07c1f9c135039606c63b88d51b93532199897ceb Author: Alan Coopersmith Date: Sun Feb 13 10:23:43 2011 -0800 Off-by-one error on the other end of FSGetErrorText bounds check The Font Server protocol actually defines 0 as an error code too. Before this fix, test/FSGetErrorText printed: FSGetErrorText for code FSBadRequest (0) returned: || Afterwards: FSGetErrorText for code FSBadRequest (0) returned: |BadRequest, invalid request code or no such operation| Signed-off-by: Alan Coopersmith commit ba4f4e7604afc23431c62c3886ab9419d5913661 Author: Alan Coopersmith Date: Sun Feb 13 10:20:48 2011 -0800 Add simple test program for FSGetErrorText() When run with arguments, prints messages for the given codes. When run with no arguments, prints messages for known valid error codes and some invalid codes. Not run as part of "make check" since it requires a connection to an xfs server to run, just available for developers to manually run when needed. Signed-off-by: Alan Coopersmith commit 3deb5cb746e94854728f8265b6bb8eeaec367322 Author: Alan Coopersmith Date: Fri Feb 11 18:32:08 2011 -0800 Off-by-one error in FSGetErrorText bounds check Read outside array bounds (CWE 125): In array dereference of with index 'code' Array size is 12 elements (of 4 bytes each), index >= 1 and index <= 12 at line 108 of libFS/src/FSErrDis.c in function 'FSGetErrorText'. [ This bug was found by the Parfait 0.3.6 bug checking tool. For more information see http://labs.oracle.com/projects/parfait/ ] Signed-off-by: Alan Coopersmith Reviewed-by: Julien Cristau commit ee8e378880e3fd3422f378b419bb77665626629c Author: Gaetan Nadon Date: Wed Feb 2 16:08:21 2011 -0500 config: splitting FS and XTRANS compiler option no longer required This was done for the wrong reasons and fixed in commit: 87c96993d17812a55d92ef32a91083614e258f02 where the libfs.pc.in was fixed. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 92a10dde49d707d79fe588bb9e5aba2534c0ab2c Author: Gaetan Nadon Date: Wed Feb 2 11:43:40 2011 -0500 config: comment, minor upgrade, quote and layout configure.ac Group statements per section as per Autoconf standard layout Quote statements where appropriate. Autoconf recommends not using dnl instead of # for comments Use AC_CONFIG_FILES to replace the deprecated AC_OUTPUT with parameters. Add AC_CONFIG_SRCDIR([Makefile.am]) Update minimum version of util-macros to at least 1.8. This helps automated maintenance and release activities. Details can be found in http://wiki.x.org/wiki/NewModuleGuidelines commit 195bc673e232e73b4cfa0fd34150a574683c69d1 Author: Gaetan Nadon Date: Fri Jan 28 19:41:37 2011 -0500 config: replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERS Signed-off-by: Gaetan Nadon commit 5895de6dedcb8603b6a415d3486395c29501868c Author: Cristian Rodríguez Date: Tue Dec 14 15:07:34 2010 -0500 Export only public API symbols Reviewed-by: Adam Jackson Signed-off-by: Cristian Rodríguez commit 4218339a30a899ceb82a9a057c6b96bce624f917 Author: Alan Coopersmith Date: Tue Oct 26 18:47:31 2010 -0700 libFS 1.0.3 Signed-off-by: Alan Coopersmith commit f6aacdb5143032a9e21b8bb09212fcf69c839a85 Author: Alan Coopersmith Date: Tue Oct 26 18:45:48 2010 -0700 Remove unnecessary calls from configure.ac AM_PROG_CC is already covered by XORG_DEFAULT_OPTIONS AC_SUBST of CFLAGS & LIBS is taken care of by PKG_CHECK_MODULES Signed-off-by: Alan Coopersmith commit c7c7dda28b61d9b008a2fab3baf8ed02662a6dbf Author: Gaetan Nadon Date: Mon Mar 29 16:50:33 2010 -0400 config: update AC_PREREQ statement to 2.60 Unrelated to the previous patches, the new value simply reflects the reality that the minimum level for autoconf to configure all x.org modules is 2.60 dated June 2006. ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz Signed-off-by: Gaetan Nadon commit dbe6f1912d77cd42ca0ac7ac5296113f84fc690e Author: Gaetan Nadon Date: Mon Mar 29 15:09:34 2010 -0400 config: install in $docdir and distribute doc/FSlib.txt The dist_doc_DATA statement was designed for that purpose. Signed-off-by: Gaetan Nadon commit 315643e773d666d1cc2248fe7ba1bc979ec34c70 Author: Gaetan Nadon Date: Mon Mar 29 14:53:48 2010 -0400 config: remove the pkgconfig pc.in file from EXTRA_DIST Automake always includes it in the tarball. Signed-off-by: Gaetan Nadon commit a391fd191e207b4408ce230505df25570cf041d4 Author: Gaetan Nadon Date: Fri Nov 27 20:56:03 2009 -0500 Makefile.am: add ChangeLog and INSTALL on MAINTAINERCLEANFILES Now that the INSTALL file is generated. Allows running make maintainer-clean. commit 15104bf1988d27e7dc4272d32dbd381455c0e9f7 Author: Gaetan Nadon Date: Wed Oct 28 14:09:10 2009 -0400 INSTALL, NEWS, README or AUTHORS files are missing/incorrect #24206 Add missing INSTALL file. Use standard GNU file on building tarball README may have been updated Remove AUTHORS file as it is empty and no content available yet. Remove NEWS file as it is empty and no content available yet. commit 491adff64c38f940ca21f6be9e370ebe90f72c3e Author: Gaetan Nadon Date: Tue Oct 27 15:07:25 2009 -0400 Deploy the new XORG_DEFAULT_OPTIONS #24242 This macro aggregate a number of existing macros that sets commmon X.Org components configuration options. It shields the configuration file from future changes. commit 1b6896d93de00ad79c28c537edead58309df0d31 Author: Gaetan Nadon Date: Mon Oct 26 22:08:41 2009 -0400 Makefile.am: ChangeLog not required: EXTRA_DIST or *CLEANFILES #24432 ChangeLog filename is known to Automake and requires no further coding in the makefile. commit 40addd2ce521edadc6e6373b80c3c8c4f73c11c1 Author: Gaetan Nadon Date: Thu Oct 22 12:34:18 2009 -0400 .gitignore: use common defaults with custom section # 24239 Using common defaults will reduce errors and maintenance. Only the very small or inexistent custom section need periodic maintenance when the structure of the component changes. Do not edit defaults. commit be177a3bad2b3158c09ebfc0356e0944ca704732 Author: Jeremy Huddleston Date: Wed Oct 21 12:47:23 2009 -0700 This is not a GNU project, so declare it foreign. On Wed, 2009-10-21 at 13:36 +1000, Peter Hutterer wrote: > On Tue, Oct 20, 2009 at 08:23:55PM -0700, Jeremy Huddleston wrote: > > I noticed an INSTALL file in xlsclients and libXvMC today, and it > > was quite annoying to work around since 'autoreconf -fvi' replaces > > it and git wants to commit it. Should these files even be in git? > > Can I nuke them for the betterment of humanity and since they get > > created by autoreconf anyways? > > See https://bugs.freedesktop.org/show_bug.cgi?id=24206 As an interim measure, replace AM_INIT_AUTOMAKE([dist-bzip2]) with AM_INIT_AUTOMAKE([foreign dist-bzip2]). This will prevent the generation of the INSTALL file. It is also part of the 24206 solution. Signed-off-by: Jeremy Huddleston commit 364af12a2426358461f5ed5b142c97411cad80c5 Author: Alan Coopersmith Date: Tue Jul 7 15:47:36 2009 -0700 Version 1.0.2 commit 040bfd8f055f7e49f15e457842b8bca4f8d2020a Author: Alan Coopersmith Date: Tue Jul 7 15:45:50 2009 -0700 Move CWARNFLAGS to Makefile.am for easier build-time overriding Signed-off-by: Alan Coopersmith commit 233b72428a47272b599a6be0708b06f7ed674f7c Author: Alan Coopersmith Date: Tue Jul 7 08:57:53 2009 -0700 Strip out-of-date RCS/CVS & SCCS version tags Signed-off-by: Alan Coopersmith commit f85f04b1287717d00cc29aaea2dc44bd59a2d2b3 Author: Alan Coopersmith Date: Tue Jul 7 08:45:41 2009 -0700 Constify FSErrorList Matches the code in libX11/src/ErrDes.c this is based on. Signed-off-by: Alan Coopersmith commit b6c63181aded7f8e8879914b0f92767a47aa47cf Author: Alan Coopersmith Date: Wed Jun 17 16:05:03 2009 -0700 Drop #ifdef USG checks for some truly ancient (pre-SVR4) SysV's Signed-off-by: Alan Coopersmith commit b566d33d344876392254941d8ef73c848194c432 Author: Alan Coopersmith Date: Wed Jun 17 15:36:54 2009 -0700 Fix server name handling in IOError messages during connection setup - Don't try to sprintf a NULL string for the server name - Initialize the server name pointer in the srv struct sooner, so errors during connection initialization can print it instead of a null string in the error message Had to update the error paths that freed the partially constructed structure, so combined them into a common implmentation via "goto fail". Signed-off-by: Alan Coopersmith commit eab796dabe05b4db2e193ab225deae613ac46a7b Author: Alan Coopersmith Date: Tue May 19 01:58:38 2009 -0700 Make FSlib.txt prototypes match those in headers. Both conversion to ANSI C89 format and fixing some long standing mistakes. Signed-off-by: Alan Coopersmith commit 39be8ae0ac4d5281a006de67ae11f7877f443bc8 Author: Alan Coopersmith Date: Tue May 19 01:44:26 2009 -0700 Move API doc from xorg-doc/doc/FSlib.doc commit 84d71a733b6ab93318260a5641d7609dbc38a198 Author: Alan Coopersmith Date: Mon Feb 2 20:34:29 2009 -0800 Add README with pointers to mailing list, bugzilla & git repos Signed-off-by: Alan Coopersmith commit 3779550c57db5fe845f955bec141ca24800f2fdb Author: Paulo Cesar Pereira de Andrade Date: Wed Jan 28 16:41:28 2009 -0200 Janitor: Correct make distcheck and compiler warnings. commit 84cd6e7402382862abb473e7686a375db29f4d99 Author: Peter Korsgaard Date: Wed Oct 22 10:34:59 2008 -0400 bcopy -> memmove commit 9cbdb6ab49d8f9e6174a00d6b509bf6f1e3c1e78 Author: Alan Coopersmith Date: Wed May 21 18:40:05 2008 -0700 Version 1.0.1 commit 16c85877e9754dfc83b7c60c9892a85d1ac14eaa Author: Alan Coopersmith Date: Wed May 21 17:44:21 2008 -0700 Replace sprintf with snprintf commit 485308a08afe17e9486f8123c775b3e728d8d88f Author: Alan Coopersmith Date: Wed May 21 17:31:15 2008 -0700 Add hooks to check code with static analyzers like lint & sparse commit 0a64482e6dcd636b9c8b2f38ecfed7945adfdb39 Author: Alan Coopersmith Date: Wed May 21 17:00:06 2008 -0700 Put all copyright/license notices into COPYING file commit 501f667cca6674704ad623a08918246ba2d2692d Author: Paulo Cesar Pereira de Andrade Date: Tue Mar 4 17:41:18 2008 -0300 libFS ansification. commit 1513378c0f71caa42fc2620e439961cc82470a61 Author: Matthieu Herrb Date: Sun Mar 9 00:16:17 2008 +0100 nuke RCS Ids commit 77f3fc68504451487bfc4ef8d393ccd95c823071 Author: James Cloos Date: Thu Dec 6 16:38:13 2007 -0500 Replace static ChangeLog with dist-hook to generate from git log commit 63fcbab9d8c6c3324d797e8ce5b52046484d2495 Author: James Cloos Date: Mon Sep 3 05:53:29 2007 -0400 Add *~ to .gitignore to skip patch/emacs droppings commit 3efa1082c4b58080b6d369882d3e6611adee8b5b Author: Alan Coopersmith Date: Thu Jul 13 14:58:43 2006 -0700 renamed: .cvsignore -> .gitignore commit df8de2bc08703b8de404e113cba4a47134bca68f Author: Kevin E Martin Date: Thu Dec 15 00:24:27 2005 +0000 Update package version number for final X11R7 release candidate. commit ea190affa767ac2c64f70bc9a303929cf2eb6eff Author: Kevin E Martin Date: Sat Dec 3 05:49:41 2005 +0000 Update package version number for X11R7 RC3 release. commit 11b1397e6c1356a70f42713f3a9779b866835d9e Author: Kevin E Martin Date: Sat Dec 3 04:41:47 2005 +0000 Add check and cflags for malloc(0) returning NULL. commit 87c96993d17812a55d92ef32a91083614e258f02 Author: Kevin E Martin Date: Sat Nov 19 07:15:39 2005 +0000 Update pkgconfig files to separate library build-time dependencies from application build-time dependencies, and update package deps to work with separate build roots. commit 2404b41c83ea49dcbf654e6448ea99ab72c8d82b Author: Kevin E Martin Date: Wed Nov 9 21:19:11 2005 +0000 Update package version number for X11R7 RC2 release. commit 516e8e27077b7c4b535189e398030f6c2c99300a Author: Kean Johnson Date: Tue Nov 8 06:33:25 2005 +0000 See ChangeLog entry 2005-11-07 for details. commit b7c75dbf546e30fba6afba95b9a95fe4f50c6bba Author: Kevin E Martin Date: Wed Oct 19 02:48:08 2005 +0000 Update package version number for RC1 release. commit 4902aa061cfdd2f2f35158240d9da9706698cf61 Author: Adam Jackson Date: Wed Aug 3 03:28:00 2005 +0000 Do PKG_CHECK_MODULES on a unique token instead of on "DEP", so builds with a global configure cache don't get confused. commit b15ff0fd68f67e37fc759742ebb637caac058f08 Author: Alan Coopersmith Date: Sat Jul 30 19:15:15 2005 +0000 Add -D flags to clear various warnings (Stefan Dirsch) commit 04ae86a006b608d2626ee90679cb84066cbc9710 Author: Alan Coopersmith Date: Sat Jul 30 19:09:37 2005 +0000 Need to include "config.h" in fs_transport.c so Xtrans knows which transport types to support commit 35facec2fbd93d176f637dda5323c16a38350dfa Author: Kevin E Martin Date: Fri Jul 29 21:22:49 2005 +0000 Various changes preparing packages for RC0: - Verify and update package version numbers as needed - Implement versioning scheme - Change bug address to point to bugzilla bug entry form - Disable loadable i18n in libX11 by default (use --enable-loadable-i18n to reenable it) - Fix makedepend to use pkgconfig and pass distcheck - Update build script to build macros first - Update modular Xorg version commit be058d899bb49c6319041d05d54ed8e289a62adf Author: Daniel Stone Date: Sat Jul 16 06:20:22 2005 +0000 Set soversion to 6.0.0 using -version-number. commit 227eb224880f912e7261d251ba2bf81992b7726f Author: Keith Packard Date: Wed Jul 13 07:27:15 2005 +0000 Eliminate xtrans CFLAGS from .pc file as xtrans is not part of the public API. commit 905552dfa2af617780bc2cd4d14edad845c3203b Author: Keith Packard Date: Wed Jul 13 07:23:56 2005 +0000 Make some minor source adjustments so that we don not need to use -D_XOPEN_SOURCE -D_BSD_SOURCE everywhere as this will leak out of the modular environment and into application build processes, potentially foulling up their compiles. commit 9a9aec0b9fb6315120c2ff87be94c6653802be76 Author: Keith Packard Date: Sat Jul 9 05:58:09 2005 +0000 Add .cvsignore files Switch _la_CFLAGS for AM_CFLAGS to clean up directory commit e5721d4ea9a1ef400f790583b33b0491a224733f Author: Daniel Stone Date: Sun Jul 3 07:00:55 2005 +0000 Add Xtrans definitions (FONT_t, TRANS_CLIENT) to clean up warnings. Add XSERV_t, TRANS_SERVER, TRANS_REOPEN to quash warnings. Add #include or , as appropriate, to all source files in the xserver/xorg tree, predicated on defines of HAVE_{DIX,XORG}_CONFIG_H. Change all Xfont includes to . commit 6847a3b405dd98a1aa7804e97e6b2ce13bbf8bd7 Author: Søren Sandmann Pedersen Date: Wed Jun 22 22:46:31 2005 +0000 Apply these patches from Theo van Klaveren: lib-dmx.patch lib-FS.patch lib-X11.patch lib-XRes.patch lib-XScrnSaver.patch lib-xtrans.patch to make the libraries distcheck. commit 5f6bbd9ed4002d9d6b5119a018bbc7345f47543a Author: Alexander Gottwald Date: Thu Jun 9 15:54:09 2005 +0000 Replace with commit e798bd7804c100232a927b075fcc58262c1e50f9 Author: Alexander Gottwald Date: Thu Jun 9 15:52:02 2005 +0000 Replace with Copy Xtrans.h to exports/include/X11/Xtrans only commit 6c0b06eddcffce31814cb103142f5cda2df9da91 Author: Søren Sandmann Pedersen Date: Wed May 25 22:12:21 2005 +0000 - Use XTRANS_CONNECTION_FLAGS macro in lib/FS/configure.ac - Don't symlink transport.c, which is a generated file - instead add a new file fs_transport.c that include Xtrans/X11/transport.c commit 3a9234d968568f2009376cdb219ea47b90572c68 Author: Søren Sandmann Pedersen Date: Wed May 25 21:47:56 2005 +0000 - Add FSlib to symlink.sh - Change Xtrans includedir back to be X11/Xtrans, so that users of it can continue to include - Add build system for FSlib - Conditionally include config.h in xc/lib/FS - Remove redundant include of FSproto.h in xc/lib/FS - Add check to proto/X11/configure.ac whether -D_XOPEN_SOURCE is needed. commit f4a1380add427a6ed7a0025d5acd5642c683900e Author: Egbert Eich Date: Fri Apr 23 18:43:08 2004 +0000 Merging XORG-CURRENT into trunk commit 7642992f5eea63b270cb8a7cbb1d470417fc47ad Author: Egbert Eich Date: Sun Mar 14 08:31:37 2004 +0000 Importing vendor version xf86-4_4_99_1 on Sun Mar 14 00:26:39 PST 2004 commit a0ded183f87e10b1202446c1824ba1b895beea9e Author: Egbert Eich Date: Wed Mar 3 12:10:54 2004 +0000 Importing vendor version xf86-4_4_0 on Wed Mar 3 04:09:24 PST 2004 commit 6b3683787c2f47eaae68276e2919b2fbbbcf72c7 Author: Egbert Eich Date: Thu Feb 26 13:35:14 2004 +0000 readding XFree86's cvs IDs commit 7e0de805849b4bb1951376600d152d0121b06b52 Author: Egbert Eich Date: Thu Feb 26 09:22:28 2004 +0000 Importing vendor version xf86-4_3_99_903 on Wed Feb 26 01:21:00 PST 2004 commit 0c5c8c10d628f28943a9cde02fb079c486ed71a3 Author: Egbert Eich Date: Thu Jan 29 08:07:56 2004 +0000 Importing vendor version xf86-012804-2330 on Thu Jan 29 00:06:33 PST 2004 commit f0345958208586004bee80bac057b651162b8a27 Author: Kaleb Keithley Date: Fri Dec 19 20:54:21 2003 +0000 XFree86 4.3.99.902 (RC 2) commit b84549f69b504b733592759c161d59a00de79ac3 Author: Kaleb Keithley Date: Tue Nov 25 19:28:02 2003 +0000 XFree86 4.3.99.16 Bring the tree up to date for the Cygwin folks commit eec6ef2ff2462876d5c6df53691b6fb2e07dfcea Author: Kaleb Keithley Date: Fri Nov 14 16:48:44 2003 +0000 XFree86 4.3.0.1 commit 9e8dd4f7585c334c5b08f05f01c8900b5e4edf52 Author: Kaleb Keithley Date: Fri Nov 14 15:54:36 2003 +0000 R6.6 is the Xorg base-line